[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/14] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helpe
From:       Richard Henderson <richard.henderson () linaro ! org>
Date:       2019-04-30 16:38:35
Message-ID: 784adbd2-0447-9d01-cff8-e7234f9d9679 () linaro ! org
[Download RAW message or body]

On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
> +#define GEN_VSX_HELPER_X2(name, op1, op2, inval, type)                        \
> +static void gen_##name(DisasContext *ctx)                                     \
> +{                                                                             \
> +    TCGv_i32 opc;                                                             \
> +    TCGv_ptr xt, xb;                                                          \
> +    if (unlikely(!ctx->vsx_enabled)) {                                        \
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);                                \
> +        return;                                                               \
> +    }                                                                         \
> +    opc = tcg_const_i32(ctx->opcode);                                         \
> +    xt = gen_vsr_ptr(xT(ctx->opcode));                                        \
> +    xb = gen_vsr_ptr(xB(ctx->opcode));                                        \
> +    gen_helper_##name(cpu_env, opc, xt, xb);                                  \

Similarly wrt opc.  However,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


[prev in list] [next in list] [prev in thread] [next in thread]