[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    Re: [PHP-CVS] com php-src: Adds initial support to generate and work with ECC public key pair: ext/o
From:       Dmitry Stogov <dmitry () zend ! com>
Date:       2016-06-29 8:55:11
Message-ID: CY1PR0201MB178624B234A33C21AFB959FBBF230 () CY1PR0201MB1786 ! namprd02 ! prod ! outlook ! com
[Download RAW message or body]


Please, never disable failed tests :(

Now only one test fails, but it fails on both Linux-32 and Linux-64.


$ cat ../ext/openssl/tests/029.diff

004+     [key] => -----BEGIN PUBLIC KEY-----
005+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNW
006+ VugYFtPg/xLQw0mHkIPZ4DvKsqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
004-     [key] => -----BEGIN PUBLIC KEY-----%a
022-     [key] => -----BEGIN PUBLIC KEY-----%a
024+     [key] => -----BEGIN PUBLIC KEY-----
025+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNW
026+ VugYFtPg/xLQw0mHkIPZ4DvKsqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
042-     [key] => -----BEGIN PUBLIC KEY-----%a
046+     [key] => -----BEGIN PUBLIC KEY-----
047+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNW
048+ VugYFtPg/xLQw0mHkIPZ4DvKsqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
068-     [key] => -----BEGIN PUBLIC KEY-----%a
074+     [key] => -----BEGIN PUBLIC KEY-----
075+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNW
076+ VugYFtPg/xLQw0mHkIPZ4DvKsqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
088-     [key] => -----BEGIN PUBLIC KEY-----%a
096+     [key] => -----BEGIN PUBLIC KEY-----
097+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNW
098+ VugYFtPg/xLQw0mHkIPZ4DvKsqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
108-     [key] => -----BEGIN PUBLIC KEY-----%a
118+     [key] => -----BEGIN PUBLIC KEY-----
119+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAExFVQseDoN08ig58Rb26eOSIG6lcV
120+ dx8E85iRYwOh6QXJm4ubEeSDfZq0xOsLTVqHCxSiTDxWzp2yHVxcnDHpIg==
134-     [key] => -----BEGIN PUBLIC KEY-----%a
146+     [key] => -----BEGIN PUBLIC KEY-----
147+ MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEHL2Pb48EG4Q90hW9/ji1LsNRd/DX
148+ oscski/odJ0T+77d4i77YEsgeGbjOk7ipM5hsWWwiLuZQNAxMDIed3E0gw==
160- bool(true)
161- bool(true)
174+
175+ Warning: openssl_pkey_get_details() expects parameter 1 to be resource, boolean \
given in /home/dmitry/php/php-master/ext/openssl/tests/029.php on line 81 176+ \
bool(false) 177+ bool(false)


If you like to test 32-bit PHP build on Linux, you should just build PHP as 32-bit \
binary on 64-bit Linux.


CC='gcc -m32 -msse2' CXX='g++ -m32 -msse2' ./configure ...

make


Of curse, you might need to install some 32-bit RPM/DEBs


Thanks. Dmitry.

________________________________
From: jakub.php@gmail.com <jakub.php@gmail.com> on behalf of Jakub Zelenka \
                <bukka@php.net>
Sent: Tuesday, June 28, 2016 10:52:28 PM
To: Dmitry Stogov
Cc: php-cvs@lists.php.net
Subject: Re: [PHP-CVS] com php-src: Adds initial support to generate and work with \
ECC public key pair: ext/openssl/openssl.c ext/openssl/tests/029.phpt \
ext/openssl/tests/ecc.phpt ext/openssl/tests/openssl_pkey_export_basic.phpt \
ext/openssl/tests/openssl_pkey_get_

Hi Dmitry,

I disabled those tests till I find time to setup 32bit VM and test it there.

Anyway if you manage to get the error diff file, that would be great as it allows me \
to make sure that I won't miss anything.

Cheers

Jakub

On Tue, Jun 28, 2016 at 10:28 AM, Jakub Zelenka <bukka@php.net<mailto:bukka@php.net>> \
wrote: Hi Dmitry,

Looks like a platform specific issue. I guess possibly 32bit as it works fine on my \
Linux 64bit and Travis passes as well.

Would you be ok to provide test diff file (after fail)?

Cheers

Jakub

On Tue, Jun 28, 2016 at 9:30 AM, Dmitry Stogov \
<dmitry@zend.com<mailto:dmitry@zend.com>> wrote:

Hi Jakob,


The following tests are broken (tested on Linux 32-bit).


> openssl_pkey_new() with EC key [ext/openssl/tests/029.phpt]
> openssl_*() with OPENSSL_KEYTYPE_EC [ext/openssl/tests/ecc.phpt]


Thanks. Dmitry.

________________________________
From: Jakub Zelenka <bukka@php.net<mailto:bukka@php.net>>
Sent: Sunday, June 26, 2016 6:15:25 PM
To: php-cvs@lists.php.net<mailto:php-cvs@lists.php.net>
Subject: [PHP-CVS] com php-src: Adds initial support to generate and work with ECC \
public key pair: ext/openssl/openssl.c ext/openssl/tests/029.phpt \
ext/openssl/tests/ecc.phpt ext/openssl/tests/openssl_pkey_export_basic.phpt \
ext/openssl/tests/openssl_pkey_get_d...

Commit:    9688138d38034c9558af45f1ebcd77c3ff88c420
Author:    Dominic Luechinger <dol@cyon.ch<mailto:dol@cyon.ch>>         Wed, 15 Jun \
                2016 22:31:42 +0200
Committer: Jakub Zelenka <bukka@php.net<mailto:bukka@php.net>>      Sun, 26 Jun 2016 \
                16:15:25 +0100
Parents:   8de8636a2b6dc331486284f1f037259bb7347768
Branches:  master

Link:       http://git.php.net/?p=php-src.git;a=commitdiff;h=9688138d38034c9558af45f1ebcd77c3ff88c420


Log:
Adds initial support to generate and work with ECC public key pair

New features:
- openssl_get_curve_names => list ECC curve names
- generate a ECC public key pair
- generate an CSR with an ECC key
- export x,y,d params of ECC public/private key

Thanks to @bukka for the review and feedback

Changed paths:
  M  ext/openssl/openssl.c
  A  ext/openssl/tests/029.phpt
  A  ext/openssl/tests/ecc.phpt
  M  ext/openssl/tests/openssl_pkey_export_basic.phpt
  M  ext/openssl/tests/openssl_pkey_get_details_basic.phpt



[prev in list] [next in list] [prev in thread] [next in thread]