[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    Re: [PHP-CVS] com php-src: Adds initial support to generate and work with ECC public key pair: ext/o
From:       Jakub Zelenka <bukka () php ! net>
Date:       2016-06-28 19:52:28
Message-ID: CAEKnhAHOeQ2ZDwV43C=yL8_uMWj4U6RZsjpzn2mnT5OUL1vNWg () mail ! gmail ! com
[Download RAW message or body]


Hi Dmitry,

I disabled those tests till I find time to setup 32bit VM and test it there.

Anyway if you manage to get the error diff file, that would be great as it
allows me to make sure that I won't miss anything.

Cheers

Jakub

On Tue, Jun 28, 2016 at 10:28 AM, Jakub Zelenka <bukka@php.net> wrote:

> Hi Dmitry,
>
> Looks like a platform specific issue. I guess possibly 32bit as it works
> fine on my Linux 64bit and Travis passes as well.
>
> Would you be ok to provide test diff file (after fail)?
>
> Cheers
>
> Jakub
>
> On Tue, Jun 28, 2016 at 9:30 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Jakob,
>>
>>
>> The following tests are broken (tested on Linux 32-bit).
>>
>>
>> > openssl_pkey_new() with EC key [ext/openssl/tests/029.phpt]
>> > openssl_*() with OPENSSL_KEYTYPE_EC [ext/openssl/tests/ecc.phpt]
>>
>>
>> Thanks. Dmitry.
>> ------------------------------
>> *From:* Jakub Zelenka <bukka@php.net>
>> *Sent:* Sunday, June 26, 2016 6:15:25 PM
>> *To:* php-cvs@lists.php.net
>> *Subject:* [PHP-CVS] com php-src: Adds initial support to generate and
>> work with ECC public key pair: ext/openssl/openssl.c
>> ext/openssl/tests/029.phpt ext/openssl/tests/ecc.phpt
>> ext/openssl/tests/openssl_pkey_export_basic.phpt
>> ext/openssl/tests/openssl_pkey_get_d...
>>
>> Commit:    9688138d38034c9558af45f1ebcd77c3ff88c420
>> Author:    Dominic Luechinger <dol@cyon.ch>         Wed, 15 Jun 2016
>> 22:31:42 +0200
>> Committer: Jakub Zelenka <bukka@php.net>      Sun, 26 Jun 2016 16:15:25
>> +0100
>> Parents:   8de8636a2b6dc331486284f1f037259bb7347768
>> Branches:  master
>>
>> Link:
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=9688138d38034c9558af45f1ebcd77c3ff88c420
>>
>> Log:
>> Adds initial support to generate and work with ECC public key pair
>>
>> New features:
>> - openssl_get_curve_names => list ECC curve names
>> - generate a ECC public key pair
>> - generate an CSR with an ECC key
>> - export x,y,d params of ECC public/private key
>>
>> Thanks to @bukka for the review and feedback
>>
>> Changed paths:
>>   M  ext/openssl/openssl.c
>>   A  ext/openssl/tests/029.phpt
>>   A  ext/openssl/tests/ecc.phpt
>>   M  ext/openssl/tests/openssl_pkey_export_basic.phpt
>>   M  ext/openssl/tests/openssl_pkey_get_details_basic.phpt
>>
>>
>


[prev in list] [next in list] [prev in thread] [next in thread]