[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [PATCH]: 0212ace999 ChangeLog: fix warning "Wide character in print" from git2cl
From:       gerrit () openocd ! org
Date:       2024-05-12 18:51:28
Message-ID: 20240512185128.2E37DEB () openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

"R. Diez <rdiezmail-openocd@yahoo.de>" just uploaded a new patch set to Gerrit, which \
you can find at https://review.openocd.org/c/openocd/+/8262

-- gerrit

commit 0212ace9998878682b205d542e899c4d8416faf5
Author: R. Diez <rdiezmail-openocd@yahoo.de>
Date:   Sun May 12 20:50:34 2024 +0200

    ChangeLog: fix warning "Wide character in print" from git2cl
    
    Change-Id: Iaefd989413753fb59642c3887807abd6ddac4b53
    Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de>

diff --git a/Makefile.am b/Makefile.am
index 1313d151b5..647b571cfa 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -114,9 +114,14 @@ TCL_PATH = tcl
 TCL_FILES = find $(srcdir)/$(TCL_PATH) -name '*.cfg' -o -name '*.tcl' -o -name \
'*.txt' | \  sed -e 's,^$(srcdir)/$(TCL_PATH),,'
 
+# Without the PERL_UNICODE="IO" workaround below when running git2cl, you get \
several +# "Wide character" warnings and you also risk an invalid character encoding \
in +# the generated ChangeLog file. For more information, see this bug report:
+#   Warning "Wide character in print"
+#   https://savannah.nongnu.org/bugs/?65689
 dist-hook:
 	if test -d $(srcdir)/.git -a \( ! -e $(distdir)/ChangeLog -o -w \
                $(distdir)/ChangeLog \) ; then \
-		git --git-dir $(srcdir)/.git log | $(srcdir)/tools/git2cl/git2cl > \
$(distdir)/ChangeLog ; \ +		git --git-dir $(srcdir)/.git log | PERL_UNICODE="IO" \
$(srcdir)/tools/git2cl/git2cl > $(distdir)/ChangeLog ; \  fi
 	for i in $$($(TCL_FILES)); do \
 		j="$(distdir)/$(TCL_PATH)/$$i" && \

-- 


[prev in list] [next in list] [prev in thread] [next in thread]