[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: RFR: 8331619: TabbedPane's contentOpaque, tabsOpaque and setOpaque doesn't work properly in Aqua
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2024-05-15 4:39:01
Message-ID: w08qqOesQY1QjQwtDtUczbNaACX2vae42Fk7Izv7z2s=.742ad851-d67c-44ef-8ef1-b73c6a60aeb2 () github ! com
[Download RAW message or body]

On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar <abhiscxk@openjdk.org> wrote:

> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua L&F. \
> JTabbedPane's content area and tab background color are not as expected when \
> tabbedpane opacity is set to true or false. Fix is to handle the opacity behavior \
> correctly and inline with other LAF as well.  
> Existing test `TestBackgroundScrollPolicy.java` failed with the proposed fix and it \
> is updated to run only for linux and windows platform because the content area for \
> tabbedpane is rendered to the width and height of tabbedpane starting from (0, 0) \
> position (https://github.com/openjdk/jdk/blob/cf7c97732320d70de5f5725c920d5c3861a2c9 \
> c8/src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java#L684C16-L684C16) \
> and that leaves no place for tab area behind tabs. 
> CI testing is green after this test update and link posted in JBS.

@DamonGuy @alisenchung Thanks for reviewing the PR but I will update the suggested \
fix or responds to them once I verify the behavior for native apps as suggested by \
@mrserb here https://github.com/openjdk/jdk/pull/19170#issuecomment-2105005574.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19170#issuecomment-2111565045


[prev in list] [next in list] [prev in thread] [next in thread]