[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: RFR: 8332103: Add missing `@since` tags to `java.desktop` [v2]
From:       Nizar Benalla <duke () openjdk ! org>
Date:       2024-05-15 3:38:29
Message-ID: I56HH0h2d1Muxv9tcPC09KolVrDFIgACzssi5TaJ46Y=.5e0cab04-d0db-4b02-b682-68f5c14793c8 () github ! com
[Download RAW message or body]

> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in #18934 \
> and are pretty simple. 
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a long \
> time so the default constructor (without parameters) didn't exist until JDK 16 
> For the `package-info` files, it is pretty hard to find source code of JDK 1-5 so I \
> used the `grep` command to find the oldest instance of an `@since` in those \
> packages. 
> I found instances of `@since 1.1` in the other packages but \
> `javax/swing/plaf/synth/package-info.java` might be worth checking as most classes \
> there had no `@since`.

Nizar Benalla has updated the pull request incrementally with one additional commit \
since the last revision:

  Swing was added in JDK 1.2

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19192/files
  - new: https://git.openjdk.org/jdk/pull/19192/files/dec1c1b5..7e8244db

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19192&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19192&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19192.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19192/head:pull/19192

PR: https://git.openjdk.org/jdk/pull/19192


[prev in list] [next in list] [prev in thread] [next in thread]