[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: <Swing Dev> [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollF
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2016-08-31 18:01:19
Message-ID: 4af938e3-b86c-406a-b499-b1e8a08a67cf () oracle ! com
[Download RAW message or body]

On 31.08.16 15:48, Semyon Sadetsky wrote:
>>> As I already mentioned it can cause several layout iterations depending
>>> on the scroll policy, L&F, etc. So, once again, it is expected behavior,
>>> and moreover it is unrelated to the current fix.
>>
>> The bug is that we call notification more time than expected, we
>> should calculate how many times it should be called and check this in
>> the test.
> The test is only checks flicker effect. These 6 notifications do not
> cause flicker. So, the test is correct.

If the test is correct why you tries to change it? The test found a bug 
when we get more notifications than expected.

>> I assume that each notification should be called when the size of
>> JViewport or View were changed?
>>
>>>>
>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 23.08.16 11:59, Alexander Scherbatiy wrote:
>>>>>>>>>>> The fix looks good to me.
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Alexandr.
>>>>>>>>>>>
>>>>>>>>>>> On 23/08/16 11:40, Semyon Sadetsky wrote:
>>>>>>>>>>>> Hello,
>>>>>>>>>>>>
>>>>>>>>>>>> Please review fix for JDK9:
>>>>>>>>>>>>
>>>>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8163167
>>>>>>>>>>>>
>>>>>>>>>>>> webrev:
>>>>>>>>>>>> http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.00/
>>>>>>>>>>>>
>>>>>>>>>>>> The cause of this test bug is revalidating JScrollPane
>>>>>>>>>>>> layout may
>>>>>>>>>>>> take
>>>>>>>>>>>> various number of iterations on different L&Fs.
>>>>>>>>>>>>
>>>>>>>>>>>> To fix the test the counter listener is added after the layout
>>>>>>>>>>>> revalidation has been started.
>>>>>>>>>>>>
>>>>>>>>>>>> --Semyon
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]