[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8318484: Initial version of cdsConfig.hpp [v2]
From:       Ioi Lam <iklam () openjdk ! org>
Date:       2023-10-21 15:46:45
Message-ID: yIY1zMshyD82dGTAe1dKvC4UOWUoCiRG8QoahwJfXPc=.cf31c4d6-f3d0-4c2d-bb07-933778d955f2 () github ! com
[Download RAW message or body]

On Thu, 19 Oct 2023 06:58:22 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Ioi Lam has updated the pull request with a new target base due to a merge or a \
> > rebase. The incremental webrev excludes the unrelated changes brought in by the \
> > merge/rebase. The pull request contains two additional commits since the last \
> > revision: 
> > - Merge branch 'master' into 8318484-initial-version-of-cdsConfig-hpp
> > - 8318484: Initial version of cdsConfig.hpp
> 
> Initial refactoring looks good. One query below.
> 
> Thanks

Thanks @dholmes-ora @calvinccheung @sspitsyn for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16257#issuecomment-1773834764


[prev in list] [next in list] [prev in thread] [next in thread]