[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
From:       Leonid Mesnik <lmesnik () openjdk ! org>
Date:       2023-10-21 3:38:41
Message-ID: KfuDlGj56pPyDBkuOtOLxehJ4jM3H_3E7tP_BoyEV-I=.86ba31ae-3111-4373-83fb-118a2ea94d77 () github ! com
[Download RAW message or body]

On Fri, 20 Oct 2023 03:20:44 GMT, Leonid Mesnik <lmesnik@openjdk.org> wrote:

> There are several failure with reason
> "Cannot invoke "String.equals(Object)" because "<local1>" is null"
> which really caused by reading the command from debugee via socket.
> Like:
> 
> String command = pipe.readln();
> 
> if (!command.equals(AbstractDebuggeeTest.COMMAND_READY)) {
> setSuccess(false);
> log.complain("TEST BUG: unknown debuggee's command: " + command);
> 
> return false;
> }
> 
> The command is null when socket fails with EOFException which usually means that \
> debugee has been crashed/exited or killed by timeout handler. 
> However, it is not clear from the error log. So
> https://bugs.openjdk.org/browse/JDK-8310940 has different problems with the same \
> NPE symptom. 
> The fix update error handling to improve logging.
> 
> So output loos like:
> 
> _open_test_hotspot_jtreg_vmTestbase_nsk_jdi_VirtualMachine_dispose_dispose002_TestDescription_java/tmp' \
>                 \
> -Dtest.compiler.opts= \
> -Dtest.java.opts= \
> -Dtest.jdk=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/images/jdk \
> -Dcompile.jdk=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/images/jdk \
> -Dtest.timeout.factor=4.0 \
> -Dtest.nativepath=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/images/test/hotspot/jtreg/native \
>                 \
> -Dtest.root=/home/lmesnik/ws/jdk-vmTestbase/open/test/hotspot/jtreg \
> -Dtest.name=vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/TestDescription.java \
>                 \
> -Dtest.file=/home/lmesnik/ws/jdk-vmTestbase/open/test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/TestDescription.java \
>                 \
> -Dtest.src=/home/lmesnik/ws/jdk-vmTestbase/open/test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002 \
>                 \
> -Dtest.src.path=/home/lmesnik/ws/jdk-vmTestbase/open/test/hotspot/jtreg/vmTestbase/n \
> sk/jdi/VirtualMachine/dispose/dispose002:/home/lmesnik/ws/jdk-vmTestbase/open/test/hotspot/jtreg/vmTestbase:/home/lmesnik/ws/jdk-vmTestbase/open/test/lib \
>                 \
> -Dtest.classes=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/test-support/jtreg_op \
> en_test_hotspot_jtreg_vmTestbase_nsk_jdi_VirtualMachine_dispose_dispose002_TestDescr \
> iption_java/classes/0/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/TestDescription.d \
>                 \
> -Dtest.class.path=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/test-support/jtreg \
> _open_test_hotspot_jtreg_vmTestbase_nsk_jdi_VirtualMachine_dispose_dispose002_TestDe \
> scription_java/classes/0/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/Te...

This pull request has now been integrated.

Changeset: 4cf195f0
Author:    Leonid Mesnik <lmesnik@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4cf195f00cae97dea6ec25751f56231530fb6aee
                
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.

Reviewed-by: sspitsyn, cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/16280


[prev in list] [next in list] [prev in thread] [next in thread]