[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: JDK-8301076: Replace NULL with nullptr in share/prims/
From:       Johan =?UTF-8?B?U2rDtmxlbg==?= <jsjolen () openjdk ! org>
Date:       2023-01-31 14:26:30
Message-ID: nrEzkTEqZR0o51sXFNwnn9kaLXLV7PkvHkMTRqB8WJk=.1a47a169-b41e-4d2f-afef-c8fe56faed3e () github ! com
[Download RAW message or body]

On Wed, 25 Jan 2023 11:47:05 GMT, Johan Sjölen <jsjolen@openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory \
> share/prims/. Unfortunately the script that does the change isn't perfect, and so \
> we need to comb through these manually to make sure nothing has gone wrong. I also \
> review these changes but things slip past my eyes sometimes. 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some \
> changes but forgot the copyright). 2. Macros having their NULL changed to nullptr, \
> these are added to the script when I find them. They should be NULL. 3. nullptr in \
> comments and logs. We try to use lower case "null" in these cases as it reads \
> better. An exception is made when code expressions are in a comment. 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking \
> about the specific value `nullptr`. 
> Thanks!

This pull request has now been integrated.

Changeset: b76a52f2
Author:    Johan Sjölen <jsjolen@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b76a52f2104b63e84e5d09f47ce01dd0cb3935d7
                
Stats:     2037 lines in 47 files changed: 0 ins; 0 del; 2037 mod

8301076: Replace NULL with nullptr in share/prims/

Reviewed-by: kbarrett, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/12188


[prev in list] [next in list] [prev in thread] [next in thread]