[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/ [v3]
From: Johan =?UTF-8?B?U2rDtmxlbg==?= <jsjolen () openjdk ! org>
Date: 2023-01-31 14:26:29
Message-ID: x-32Uf435B3_bQl7i7GqmbOFmMKxCXq1w-fjssxQyLk=.73dfe369-e987-4d2a-9b6d-bfa7afeb5c69 () github ! com
[Download RAW message or body]
On Tue, 31 Jan 2023 10:11:34 GMT, Johan Sjölen <jsjolen@openjdk.org> wrote:
> > Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory \
> > share/prims/. Unfortunately the script that does the change isn't perfect, and so \
> > we need to comb through these manually to make sure nothing has gone wrong. I \
> > also review these changes but things slip past my eyes sometimes.
> > Here are some typical things to look out for:
> >
> > 1. No changes but copyright header changed (probably because I reverted some \
> > changes but forgot the copyright). 2. Macros having their NULL changed to \
> > nullptr, these are added to the script when I find them. They should be NULL. 3. \
> > nullptr in comments and logs. We try to use lower case "null" in these cases as \
> > it reads better. An exception is made when code expressions are in a comment.
> > An example of this:
> >
> > ```c++
> > // This function returns null
> > void* ret_null();
> > // This function returns true if *x == nullptr
> > bool is_nullptr(void** x);
> >
> >
> > Note how `nullptr` participates in a code expression here, we really are talking \
> > about the specific value `nullptr`.
> > Thanks!
>
> Johan Sjölen has updated the pull request incrementally with one additional commit \
> since the last revision:
> Fix dholmes's suggested changes
Tier1 is passing and this has 2 approvals, I'm integrating. Thank you for the \
reviews.
-------------
PR: https://git.openjdk.org/jdk/pull/12188
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic