[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]
From:       Mikhailo Seledtsov <mseledtsov () openjdk ! java ! net>
Date:       2021-08-17 23:26:27
Message-ID: 6nxeZAJ9wzVs6WB41Jcfx-4d3iQ24BJ78aPLA6Mmdpc=.e1298d97-a3cd-44b0-a482-3f51c90b3532 () github ! com
[Download RAW message or body]

On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov <mseledtsov@openjdk.org> wrote:

> > Please review this change that updates the buildJdkDockerImage() test library \
> > API. 
> > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l support \
> > for containers is not tested". The initial intent was to extend the \
> > buildJdkDockerImage() API of DockerTestUtils to accept custom Dockerfile content. \
> >                 As I analyzed the usage of buildJdkDockerImage() I realized that:
> > - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest"
> > its use has been obsolete for some time, in favor of Dockerfile generated by \
> >                 DockerTestUtils
> > - 3rd argument "buildDirName" is also always the same: "jdk-docker"
> > 
> > Hence I thought it would be a good idea to simplify this API and make it \
> > up-to-date. 
> > Also, since the method signature is being updated, I thought it would be a good \
> > idea to also change the name to use more generic container terminology: \
> > buildJdkDockerImage() --> buildJdkContainerImage()
> 
> Mikhailo Seledtsov has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fixed a comment

Igor, Harold, thank you for review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5134


[prev in list] [next in list] [prev in thread] [next in thread]