[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8272398: Update DockerTestUtils.buildJdkDockerImage()
From:       Mikhailo Seledtsov <mseledtsov () openjdk ! java ! net>
Date:       2021-08-17 23:26:28
Message-ID: 36l3IOw3PFT9woDJaDBUSztd7XkzYJWeCEX2lZvTwI4=.dff81de4-b593-4519-afc9-4a8fab496ec2 () github ! com
[Download RAW message or body]

On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov <mseledtsov@openjdk.org> wrote:

> Please review this change that updates the buildJdkDockerImage() test library API.
> 
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l support \
> for containers is not tested". The initial intent was to extend the \
> buildJdkDockerImage() API of DockerTestUtils to accept custom Dockerfile content. \
>                 As I analyzed the usage of buildJdkDockerImage() I realized that:
> - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest"
> its use has been obsolete for some time, in favor of Dockerfile generated by \
>                 DockerTestUtils
> - 3rd argument "buildDirName" is also always the same: "jdk-docker"
> 
> Hence I thought it would be a good idea to simplify this API and make it \
> up-to-date. 
> Also, since the method signature is being updated, I thought it would be a good \
> idea to also change the name to use more generic container terminology: \
> buildJdkDockerImage() --> buildJdkContainerImage()

This pull request has now been integrated.

Changeset: ec63957f
Author:    Mikhailo Seledtsov <mseledtsov@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ec63957f9d103e86d3b8e235e79cabb8992cb3ca
                
Stats:     68 lines in 17 files changed: 20 ins; 13 del; 35 mod

8272398: Update DockerTestUtils.buildJdkDockerImage()

Reviewed-by: iignatyev, hseigel

-------------

PR: https://git.openjdk.java.net/jdk/pull/5134


[prev in list] [next in list] [prev in thread] [next in thread]