[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8261447: MethodInvocationCounters frequently run into overflow [v8]
From:       Martin Doerr <mdoerr () openjdk ! java ! net>
Date:       2021-02-25 9:53:41
Message-ID: OP0SNLcg3VCRecXWPim1t-q49tpNXk-xIZFqAxvw4DQ=.4cdcc86b-a679-466d-bdd6-ba4eaebb8321 () github ! com
[Download RAW message or body]

On Thu, 25 Feb 2021 09:01:10 GMT, Lutz Schmidt <lucy@openjdk.org> wrote:

> > Dear community,
> > may I please request reviews for this fix, improving the usefulness of method \
> >                 invocation counters.
> > - aggregation counters are retyped as uint64_t, shifting the overflow probability \
> >                 way out (> 500 years in case of a 1 GHz counter update \
> >                 frequency).
> > - counters for individual methods are interpreted as (unsigned int), in contrast \
> > to their declaration as int. This gives us a factor of two before the counters \
> >                 overflow.
> > - as a special case, "compiled_invocation_counter" is retyped as long, because it \
> >                 has a higher update frequency than other counters.
> > - before/after sample output is attached to the bug description. 
> > 
> > Thank you!
> > Lutz
> 
> Lutz Schmidt has updated the pull request incrementally with one additional commit \
> since the last revision: 
> comment changes requested by TheRealMDoerr

Marked as reviewed by mdoerr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2511


[prev in list] [next in list] [prev in thread] [next in thread]