[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "li
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2020-11-30 23:53:55
Message-ID: WlUrhJ_x4QiEwFRn7gxAjh4bbnozKn2iP2uUuP2ueQ8=.89f8eefd-68bf-4cdd-b380-6c92f7128155 () github ! com
[Download RAW message or body]

On Wed, 25 Nov 2020 21:36:12 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> JdbTest can get exception before jdb field is initialized.
> As Jdb logging does not depend on the instance, made Jdb.log method static

Hi Alex,
It looks good.
I do not object against of getting rid of the Jdb.log method if there are no other dependencies.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1443
[prev in list] [next in list] [prev in thread] [next in thread]