[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8256718: Obsolete the long term deprecated and aliased Trace flags
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2020-11-30 23:44:55
Message-ID: NxliSMV1UtsGGaiGmKDjYszNJHva9eJF2BBlqQHOS8c=.9d984e79-4150-4fb2-ac9f-6e3e9b1713e0 () github ! com
[Download RAW message or body]

On Mon, 30 Nov 2020 21:13:05 GMT, Harold Seigel <hseigel@openjdk.org> wrote:

> Please review this change to obsolete the deprecated and aliased Trace flags.  The \
> now empty aliased_logging_flags support was left in arguments.cpp for use by trace \
> flags that get deprecated and aliased in the future. 
> With this change, users will get the following example messages when using these \
> obsolete flags, depending on whether -XX:+... or -XX:-... was specified: 
> VM warning: Ignoring option TraceClassPaths; support was removed in 16.0.  Please \
> use -Xlog:class+path=info instead. 
> VM warning: Ignoring option TraceClassPaths; support was removed in 16.0.  Please \
> use -Xlog:class+path=off instead. 
> The change was tested with tiers1and 2 on Linux, Windows, and MacOS, and tiers 3-5 \
> on Linux x64 and with JCK lang and vm tests. 
> Thanks, Harold

Hi Harold,

The fix looks okay to me.
I was more focusing on the serviceability flags.
I'm not sure the flag `TraceJVMTIObjectTagging` should be mentioned in the \
`src/java.base/share/man/java.1` the same way as the `TraceRedefineClasses`.

Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1525


[prev in list] [next in list] [prev in thread] [next in thread]