[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    =?UTF-8?Q?Re=3A_RFR=28S=29=3A_8227645=3A_Some_tests_in_serviceability=2Fsa?= =?UTF-8?Q?_run_with_fix
From:       Jean Christophe Beyler <jcbeyler () google ! com>
Date:       2019-08-08 11:31:19
Message-ID: CAF9BGBybkKbDkShj6Lo4xo9DNW72iOHVcEL-7iyMCAxM+6T=1A () mail ! gmail ! com
[Download RAW message or body]

Hi Chris,

Looks good to me,
Jc

On Wed, Aug 7, 2019 at 6:57 PM Chris Plummer <chris.plummer@oracle.com>
wrote:

> Hello,
>
> Please review the following:
>
> http://cr.openjdk.java.net/~cjplummer/8227645/webrev.00/webrev.open/
> https://bugs.openjdk.java.net/browse/JDK-8227645
>
> I moved the offending tests to their own directory and added
> "exclusiveAccess.dirs=." for that directory. There were two extra
> support classes I had to move also (they aren't tests), and also a minor
> @library fix due to a dependency on another file in the sa test directory.
>
> thanks,
>
> Chris
>


-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr">Hi Chris,<div><br></div><div>Looks good to \
me,</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, Aug 7, 2019 at 6:57 PM Chris Plummer &lt;<a \
href="mailto:chris.plummer@oracle.com">chris.plummer@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <br>
Please review the following:<br>
<br>
<a href="http://cr.openjdk.java.net/~cjplummer/8227645/webrev.00/webrev.open/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~cjplummer/8227645/webrev.00/webrev.open/</a><br>
 <a href="https://bugs.openjdk.java.net/browse/JDK-8227645" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8227645</a><br> <br>
I moved the offending tests to their own directory and added <br>
&quot;exclusiveAccess.dirs=.&quot; for that directory. There were two extra <br>
support classes I had to move also (they aren&#39;t tests), and also a minor <br>
@library fix due to a dependency on another file in the sa test directory.<br>
<br>
thanks,<br>
<br>
Chris<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]