[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [aarch64-port-dev ] RFR: 8229118: [TESTBUG] serviceability/sa/ClhsdbFindPC fails on AArch64
From:       Andrew Haley <aph () redhat ! com>
Date:       2019-08-08 10:37:05
Message-ID: cc95fd29-8048-ae0f-098c-0569b4170aa0 () redhat ! com
[Download RAW message or body]

On 8/8/19 11:16 AM, Andrew Dinn wrote:
> I'm not 100% clear what the point of this test is but it looks like it
> is meant to exercise the stack backtrace code when there is a compiled
> method on the stack. If so then I guess your hack fits the bill while
> removing the -Xcomp flag from the command line would not fulfil the
> test's remit. If that is the point of the test then I agree,
> reluctantly, that your hack is the right solution. On those grounds I'm
> happy to accept the patch. However, I'd prefer someone else (Andrew
> Haley?) also to review this before it gets pushed.

Eww. I suppose that -Xcomp often always fails on AArch64 because we
deoptimize so readily. Given that the test is not supposed to be
testing -Xcomp but SA I guess the test is OK, but it's very fragile.

It does mean that any tests which depend on -Xcomp don't really work
on AArch64.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
[prev in list] [next in list] [prev in thread] [next in thread]