[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (S) 8224020: AsyncGetCallTrace test should not run on PPC64 or IA64
From: Jean Christophe Beyler <jcbeyler () google ! com>
Date: 2019-05-16 20:58:00
Message-ID: CAF9BGByuKHgWABrfqe3V2XPmnPOD0TQ25yYdaB3QCgP7mrEm2g () mail ! gmail ! com
[Download RAW message or body]
Thanks all, I pushed it like this then because it seems more "incremental",
Jc
On Thu, May 16, 2019 at 7:08 AM Volker Simonis <volker.simonis@gmail.com>
wrote:
> Hi Jc,
>
> from the perspective of the ppc64 and s390 port it is OK to exclude
> the two platforms from the test. When we will fix AGCT on the two
> platforms we will update the tests.
>
> Thanks,
> Volker
>
> On Thu, May 16, 2019 at 4:57 AM Jean Christophe Beyler
> <jcbeyler@google.com> wrote:
> >
> > Hi both,
> >
> > For the linux question, I was doing that less for the AGCT code itself
> but more for the dlsym I was doing in the test; I was not really wanting to
> support the various ways of getting the function pointer in the first
> iteration of the test. If we wanted to add it, I would prefer to do a
> separate bug/webrev to add it in a second step (For example, my theory is
> that dlsym works on mac but I'm not sure of the support there either).
> >
> > I like the idea of trying to only know what architectures are supported.
> From what I can tell, if I restrain my inspection to linux:
> >
> > For the linux ports and pd_get_top_frame_for_signal_handler:
> > - aarch64, arm, ppc, sparc, x86 seem to have an implementation (or it
> calls the for_profiling_one)
> > - zero, s390 do not
> >
> > On the AsyncGetCallTrace itself, it seems like the #ifndef around the
> call that removes ppc64/ia64 is what is blocking it for ppc at least.
> >
> > Which means that on linux, we should remove zero, s390, ia64, and ppc64;
> or as you are suggesting allow aarch64, arm, sparc, and x86.
> >
> > I offer thus:
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.01/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8224020
> >
> > Thanks for the reviews!
> > Jc
> >
> >
> >
> > From: serguei.spitsyn@oracle.com <serguei.spitsyn@oracle.com>
> > Date: Wed, May 15, 2019 at 7:44 PM
> > To: Chris Plummer, Jean Christophe Beyler, OpenJDK Serviceability
> >
> >> Hi Jc,
> >>
> >> I'm Okay with this fix in general modulo some suggestion from Chris
> below.
> >>
> >>
> >> On 5/15/19 18:49, Chris Plummer wrote:
> >>
> >> Hi JC,
> >>
> >> Looks like s390 is also not supported. Do we know for usre if it is
> implemented on other architectures, like aarch64? I wouldn't necessarily
> rely on the lack of a negative comment in
> JavaThread::pd_get_top_frame_for_signal_handler() to determine support.
> Maybe the test should list supported platforms rather than unsupported ones.
> >>
> >>
> >> I like the suggestion above.
> >> It is better to list what is supported now.
> >>
> >> Also, why does the test currently require linux?
> >>
> >>
> >> My guess is that Jc does not have other platforms to check it on.
> >> Probably, it is Okay for now to keep it this way.
> >> Then we could file an RFE, check if ASGCT tests work Okay on other
> OS'es and relax this limitation.
> >>
> >> Thanks,
> >> Serguei
> >>
> >>
> >> Chris
> >>
> >> On 5/15/19 6:01 PM, Jean Christophe Beyler wrote:
> >>
> >> Hi all,
> >>
> >> Could I get a review that restricts the test to not run on PPC64/IA64
> please?
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8224020
> >> Webrev: http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.00/
> >>
> >> I also moved NULL -> RTLD_DEFAULT as the man page on linux does not
> specify the behavior of passing NULL.
> >>
> >> Thanks,
> >> Jc
> >>
> >>
> >>
> >
> >
> > --
> >
> > Thanks,
> > Jc
>
--
Thanks,
Jc
[Attachment #3 (text/html)]
<div dir="ltr">Thanks all, I pushed it like this then because it seems more \
"incremental",<div>Jc</div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Thu, May 16, 2019 at 7:08 AM Volker Simonis <<a \
href="mailto:volker.simonis@gmail.com">volker.simonis@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jc,<br> <br>
from the perspective of the ppc64 and s390 port it is OK to exclude<br>
the two platforms from the test. When we will fix AGCT on the two<br>
platforms we will update the tests.<br>
<br>
Thanks,<br>
Volker<br>
<br>
On Thu, May 16, 2019 at 4:57 AM Jean Christophe Beyler<br>
<<a href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a>> \
wrote:<br> ><br>
> Hi both,<br>
><br>
> For the linux question, I was doing that less for the AGCT code itself but more \
for the dlsym I was doing in the test; I was not really wanting to support the \
various ways of getting the function pointer in the first iteration of the test. If \
we wanted to add it, I would prefer to do a separate bug/webrev to add it in a second \
step (For example, my theory is that dlsym works on mac but I'm not sure of the \
support there either).<br> ><br>
> I like the idea of trying to only know what architectures are supported. From \
what I can tell, if I restrain my inspection to linux:<br> ><br>
> For the linux ports and pd_get_top_frame_for_signal_handler:<br>
> - aarch64, arm, ppc, sparc, x86 seem to have an implementation (or it calls \
the for_profiling_one)<br> > - zero, s390 do not<br>
><br>
> On the AsyncGetCallTrace itself, it seems like the #ifndef around the call that \
removes ppc64/ia64 is what is blocking it for ppc at least.<br> ><br>
> Which means that on linux, we should remove zero, s390, ia64, and ppc64; or as \
you are suggesting allow aarch64, arm, sparc, and x86.<br> ><br>
> I offer thus:<br>
> Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.01/</a><br>
> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8224020" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8224020</a><br>
><br>
> Thanks for the reviews!<br>
> Jc<br>
><br>
><br>
><br>
> From: <a href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a> <<a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>><br> > Date: Wed, May 15, 2019 \
at 7:44 PM<br> > To: Chris Plummer, Jean Christophe Beyler, OpenJDK \
Serviceability<br> ><br>
>> Hi Jc,<br>
>><br>
>> I'm Okay with this fix in general modulo some suggestion from Chris \
below.<br> >><br>
>><br>
>> On 5/15/19 18:49, Chris Plummer wrote:<br>
>><br>
>> Hi JC,<br>
>><br>
>> Looks like s390 is also not supported. Do we know for usre if it is \
implemented on other architectures, like aarch64? I wouldn't necessarily rely on \
the lack of a negative comment in JavaThread::pd_get_top_frame_for_signal_handler() \
to determine support. Maybe the test should list supported platforms rather than \
unsupported ones.<br> >><br>
>><br>
>> I like the suggestion above.<br>
>> It is better to list what is supported now.<br>
>><br>
>> Also, why does the test currently require linux?<br>
>><br>
>><br>
>> My guess is that Jc does not have other platforms to check it on.<br>
>> Probably, it is Okay for now to keep it this way.<br>
>> Then we could file an RFE, check if ASGCT tests work Okay on other OS'es \
and relax this limitation.<br> >><br>
>> Thanks,<br>
>> Serguei<br>
>><br>
>><br>
>> Chris<br>
>><br>
>> On 5/15/19 6:01 PM, Jean Christophe Beyler wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> Could I get a review that restricts the test to not run on PPC64/IA64 \
please?<br> >><br>
>> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8224020" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8224020</a><br>
>> Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.00/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8224020/webrev.00/</a><br>
>><br>
>> I also moved NULL -> RTLD_DEFAULT as the man page on linux does not \
specify the behavior of passing NULL.<br> >><br>
>> Thanks,<br>
>> Jc<br>
>><br>
>><br>
>><br>
><br>
><br>
> --<br>
><br>
> Thanks,<br>
> Jc<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic