[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8221713: JDWP spec - allow option is not described
From:       Jean Christophe Beyler <jcbeyler () google ! com>
Date:       2019-05-16 19:52:07
Message-ID: CAF9BGBz43NBf-zN3epNmGStVj8bsYNisAmc0-Tq5_hKx4v1g-Q () mail ! gmail ! com
[Download RAW message or body]

Hi Alex,

Only nit I saw was:

+    For IPv4 prefix length must be in range 1..31, for IPv6 - in range
1..127.

to


+    For IPv4, the prefix length must be in range 1..31; for IPv6, the
range must be 1..127.

No need of a new webrev if you do change it of course :)
Jc

On Thu, May 16, 2019 at 12:18 PM Alex Menkov <alexey.menkov@oracle.com>
wrote:

> Hi all,
>
> Back in JDK10 "allow" option was implemented for dt_socket transport:
> https://bugs.openjdk.java.net/browse/JDK-8061228
> CCC: https://bugs.openjdk.java.net/browse/CCC-8061228
> But this option was not reflected in "Connection and Invocation Details"
> page.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8221713
> webrev: http://cr.openjdk.java.net/~amenkov/docs/allow/webrev/
>
> results:
> old: http://cr.openjdk.java.net/~amenkov/docs/allow/0/conninv.html
> new: http://cr.openjdk.java.net/~amenkov/docs/allow/1/conninv.html
>
> specdiff:
> http://cr.openjdk.java.net/~amenkov/docs/allow/conninv.specdiff/diff.html
>
> --alex
>


-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi Alex,<div><br></div><div>Only nit I \
saw was:</div><div><div><br></div><div>+      For IPv4 prefix length must be in range \
1..31, for IPv6 - in range \
1..127.</div></div><div><br></div><div>to</div><div><br></div><div><div><br></div><div>+ \
For IPv4, the prefix length must be in range 1..31;  for IPv6, the range must be \
1..127.</div></div><div><br></div><div>No need of a new webrev if you do change it of \
course :)</div><div>Jc</div></div></div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Thu, May 16, 2019 at 12:18 PM Alex Menkov &lt;<a \
href="mailto:alexey.menkov@oracle.com">alexey.menkov@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,<br> <br>
Back in JDK10 &quot;allow&quot; option was implemented for dt_socket transport:<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8061228" rel="noreferrer" \
                target="_blank">https://bugs.openjdk.java.net/browse/JDK-8061228</a><br>
                
CCC: <a href="https://bugs.openjdk.java.net/browse/CCC-8061228" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/CCC-8061228</a><br> But this \
option was not reflected in &quot;Connection and Invocation Details&quot; <br> \
page.<br> <br>
JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8221713" rel="noreferrer" \
                target="_blank">https://bugs.openjdk.java.net/browse/JDK-8221713</a><br>
                
webrev: <a href="http://cr.openjdk.java.net/~amenkov/docs/allow/webrev/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~amenkov/docs/allow/webrev/</a><br>
 <br>
results:<br>
old: <a href="http://cr.openjdk.java.net/~amenkov/docs/allow/0/conninv.html" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~amenkov/docs/allow/0/conninv.html</a><br>
                
new: <a href="http://cr.openjdk.java.net/~amenkov/docs/allow/1/conninv.html" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~amenkov/docs/allow/1/conninv.html</a><br>
 <br>
specdiff: <br>
<a href="http://cr.openjdk.java.net/~amenkov/docs/allow/conninv.specdiff/diff.html" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~amenkov/docs/allow/conninv.specdiff/diff.html</a><br>
 <br>
--alex<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]