[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(L) : 8199371 : [TESTBUG] Open source vm testbase JDWP tests
From:       Mikhailo Seledtsov <mikhailo.seledtsov () oracle ! com>
Date:       2018-05-31 3:41:06
Message-ID: 5B0F6ED2.10005 () oracle ! com
[Download RAW message or body]

+1

Misha

On 5/30/18, 3:43 PM, serguei.spitsyn@oracle.com wrote:
> Hi Igor,
>
> The fix looks good.
> At least, I do not see any issues.
>
> Thanks,
> Serguei
>
>
> On 5/29/18 16:22, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8199371/webrev.00/index.html
>>> 64675 lines changed: 64675 ins; 0 del; 0 mod;
>> Hi all,
>>
>> could you please review this patch which open sources JDWP tests from 
>> VM testbase?
>>
>> As usually w/ VM testbase code, these tests are old, they have been 
>> run in hotspot testing for a long period of time. Originally, these 
>> tests were run by a test harness different from jtreg and had 
>> different build and execution schemes, some parts couldn't be easily 
>> translated to jtreg, so tests might have actions or pieces of code 
>> which look weird. In a long term, we are planning to rework them.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8199371
>> webrev: 
>> http://cr.openjdk.java.net/~iignatyev//8199371/webrev.00/index.html
>> testing: :vmTestbase_vm_jdwp test group
>>
>> Thanks,
>> -- Igor
>
[prev in list] [next in list] [prev in thread] [next in thread]