[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RFR: 8196521: serviceability/sa/ClhsdbWhere.java fails to find method 'waitForReferencePendingList'
From: stewartd.qdt <stewartd.qdt () qualcommdatacenter ! com>
Date: 2018-01-31 21:09:30
Message-ID: 71d86c90cba444c6967883078e5c5cc3 () NASANEXM01E ! na ! qualcomm ! com
[Download RAW message or body]
Please review this webrev [1] which attempts to fix a test error in service=
ability/sa/ClhsdbWhere.java when it is run under an AArch64 system (not nec=
essarily exclusive to this system, but it was the system under test). The b=
ug report [2] provides further details and has the jtr report that was gene=
rated. Essentially the line "waitForReferencePendingList" never actually oc=
curs. The test is written such that it is expecting that line.
This patch simply removes the line from the set of tested lines it expects.=
I'm not overly happy with this approach as it actually removes a test lin=
e. However, the test line does not actually appear in the output (at least =
on my system) and I'm not sure if there is actually another way of testing =
for the intent of this line or if it doesn't actually have to appear in the=
output, depending on the system. Perhaps the original author could chime i=
n and provide further guidance as to the intention of the test.
I am happy to modify the patch as necessary.
Regards,
Daniel Stewart
[1] - http://cr.openjdk.java.net/~dstewart/8196521/webrev.00/
[2] - https://bugs.openjdk.java.net/browse/JDK-8196521
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Please review this webrev [1] which attempts to fix a test error \
in serviceability/sa/ClhsdbWhere.java when it is run under an AArch64 system (not \
necessarily exclusive to this system, but it was the system under test). The bug \
report [2] provides further details and has the jtr report that was generated. \
Essentially the line “waitForReferencePendingList” never actually occurs. \
The test is written such that it is expecting that line. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This patch simply removes the line from the set of tested lines \
it expects. I’m not overly happy with this approach as it actually \
removes a test line. However, the test line does not actually appear in the output \
(at least on my system) and I’m not sure if there is actually another way of \
testing for the intent of this line or if it doesn’t actually have to appear in \
the output, depending on the system. Perhaps the original author could chime in and \
provide further guidance as to the intention of the test. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I am happy to modify the patch as necessary. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Daniel Stewart<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[1] - <a \
href="http://cr.openjdk.java.net/~dstewart/8196521/webrev.00/"> \
http://cr.openjdk.java.net/~dstewart/8196521/webrev.00/</a><o:p></o:p></p> <p \
class="MsoNormal">[2] - <a href="https://bugs.openjdk.java.net/browse/JDK-8196521"> \
https://bugs.openjdk.java.net/browse/JDK-8196521</a><o:p></o:p></p> <p \
class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic