[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse float if non US locale.
From:       Volker Simonis <volker.simonis () gmail ! com>
Date:       2017-07-28 14:44:46
Message-ID: CA+3eh10xwVG1qGoNN9=C5u=2Or3tb8TgLc8g6pA__mp82671_A () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jul 28, 2017 at 9:30 AM, Lindenmaier, Goetz
<goetz.lindenmaier@sap.com> wrote:
> Hi Volker,
>
> thanks for looking at this change!
>
>> Looks good, but don't we also need this for getIntValue() as well?
> This class is a helper class for testing jstat. To my
> knowledge jstat never formats integers, so the
> current parsing should cover all possible outputs
> to be tested.
>

OK, I don't want to unnecessarily block this change but IMO if we
don't need the integer parsing function at all we should remove it or
otherwise change it to use NumberFormat as well.

Regards,
Volker

> Best regards,
>   Goetz.
>
>> -----Original Message-----
>> From: Volker Simonis [mailto:volker.simonis@gmail.com]
>> Sent: Thursday, July 27, 2017 11:49 AM
>> To: Lindenmaier, Goetz <goetz.lindenmaier@sap.com>
>> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) <serviceability-
>> dev@openjdk.java.net>; Zeller, Arno <arno.zeller@sap.com>
>> Subject: Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse
>> float if non US locale.
>>
>> Looks good, but don't we also need this for getIntValue() as well?
>> I.e. can't an integer be "1.234.678" (German style) as well as
>> "1,234,678" (American style) for example ?
>>
>> Thanks,
>> Volker
>>
>> On Mon, Jul 24, 2017 at 9:07 AM, Lindenmaier, Goetz
>> <goetz.lindenmaier@sap.com> wrote:
>> > Hi,
>> >
>> >
>> >
>> > Some tests use Float.valueOf for String to float converting. If an other
>> > locale than US is used the test failed. We observed this on Mac.
>> > Changed to use NumberFormat to work with all locales.
>> >
>> >
>> >
>> > Please review this change. I please need a sponsor.
>> >
>> > http://cr.openjdk.java.net/~goetz/wr17/8185112-macLocale/webrev.01/
>> >
>> >
>> >
>> > Best regards,
>> >
>> >   Goetz
[prev in list] [next in list] [prev in thread] [next in thread]