[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR: JDK-6760477 - Update SA to include stack traces in the heap dump
From: Sharath Ballal <sharath.ballal () oracle ! com>
Date: 2017-06-01 15:21:00
Message-ID: cfb22450-24d9-45c7-a999-bc5d18df82c5 () default
[Download RAW message or body]
Thanks Jini. I have addressed both the comments.
> * Looks like the stackTraces array list is unused.
Done. The reason of adding this was for use at other places which may require the \
stack trace.
> * HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 and \
> similar instances with 2 * INT_SIZE.
Done
Thanks & Regards,
Sharath Ballal
From: Jini George
Sent: Tuesday, May 30, 2017 2:56 PM
To: Sharath Ballal; serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-6760477 - Update SA to include stack traces in the heap dump
Hi Sharath,
Looks good. A few nits.
* Looks like the stackTraces array list is unused.
* HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 and similar \
instances with 2 * INT_SIZE.
Thanks,
Jini.
On 5/29/2017 4:14 PM, Sharath Ballal wrote:
Hi,
Pls review the fix for including stack traces in the heap dump in SA.
Bug: https://bugs.openjdk.java.net/browse/JDK-6760477
Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/"http://cr.openjdk.java.net/~sballal/6760477/webrev.00/ \
Thanks & Regards,
Sharath Ballal
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
tt
{mso-style-priority:99;
font-family:"Courier New";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='color:#1F497D'>Thanks Jini. I have addressed both the \
comments.<o:p></o:p></span></p><p class=MsoNormal><tt><span \
style='font-size:10.0pt'>> * Looks like the stackTraces array list is unused. \
</span></tt><span style='font-size:10.0pt;font-family:"Courier New"'><br>Done. \
The reason of adding this was for use at other places which may require the stack \
trace.<br><tt>> * HeapHprofBinWriter.java: Line 764: It might be better to replace \
2 * 4 and similar instances with 2 * INT_SIZE.</tt><br>Done<br><br></span><span \
style='color:#1F497D'><o:p></o:p></span></p><div><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span style='font-size:12.0pt;color:#1F497D'>Thanks & \
Regards,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath Ballal<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'><o:p> </o:p></span></p></div><p \
class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> Jini \
George <br><b>Sent:</b> Tuesday, May 30, 2017 2:56 PM<br><b>To:</b> Sharath Ballal; \
serviceability-dev@openjdk.java.net<br><b>Subject:</b> Re: RFR: JDK-6760477 - Update \
SA to include stack traces in the heap dump<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal \
style='margin-bottom:12.0pt'><tt><span style='font-size:10.0pt'>Hi \
Sharath,</span></tt><span style='font-size:10.0pt;font-family:"Courier \
New"'><br><br><tt>Looks good. A few nits.</tt><br><br><tt>* Looks like the \
stackTraces array list is unused. </tt><br><br><tt>* HeapHprofBinWriter.java: Line \
764: It might be better to replace 2 * 4 and similar instances with 2 * \
INT_SIZE.</tt><br><br><tt>Thanks,</tt><br><tt>Jini.</tt></span><o:p></o:p></p><div><p \
class=MsoNormal>On 5/29/2017 4:14 PM, Sharath Ballal \
wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi,<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Pls review the fix for \
including stack traces in the heap dump in SA.<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-6760477">https://bugs.openjdk.java.net/browse/JDK-6760477</a> \
<o:p></o:p></p><p class=MsoNormal>Webrev: <a \
href="http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/">http://cr.openjdk.java.net/~sballal/6760477/webrev.00/</a> \
<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'> </span><o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'>Thanks & Regards,</span><o:p></o:p></p><p \
class=MsoNormal><span style='font-size:12.0pt'>Sharath Ballal</span><o:p></o:p></p><p \
class=MsoNormal><span style='font-size:12.0pt'> </span><o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p></blockquote><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New \
Roman","serif"'><o:p> </o:p></span></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic