[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-6760477 - Update SA to include stack traces in the heap dump
From:       Jini George <jini.george () oracle ! com>
Date:       2017-05-30 9:37:38
Message-ID: 2078e8c7-1394-e695-674e-ec072791b48b () oracle ! com
[Download RAW message or body]

Hi Sharath,

Looks good. A few nits.

* Looks like the stackTraces array list is unused.

* HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4 
and similar instances with 2 * INT_SIZE.

Thanks,
Jini.

On 5/29/2017 4:14 PM, Sharath Ballal wrote:
>
> Hi,
>
> Pls review the fix for including stack traces in the heap dump in SA.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6760477
>
> Webrev: http://cr.openjdk.java.net/~sballal/6760477/webrev.00/ 
> <http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/>
>
> Thanks & Regards,
>
> Sharath Ballal
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <tt>Hi Sharath,<br>
      <br>
      Looks good. A few nits.<br>
      <br>
    </tt><tt>* Looks like the stackTraces array list is unused. <br>
      <br>
      * HeapHprofBinWriter.java: Line 764: It might be better to replace
      2 * 4 and similar instances with 2 * INT_SIZE.<br>
      <br>
      Thanks,<br>
      Jini.<br>
    </tt><br>
    <div class="moz-cite-prefix">On 5/29/2017 4:14 PM, Sharath Ballal
      wrote:<br>
    </div>
    <blockquote cite="mid:2091a3f7-af89-4c8e-803a-22b4848c8788@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <meta name="Generator" content="Microsoft Word 12 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal">Hi,<o:p></o:p></p>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal">Pls review the fix for including stack
          traces in the heap dump in SA.<o:p></o:p></p>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal">Bug:    <a moz-do-not-send="true"
            href="https://bugs.openjdk.java.net/browse/JDK-6760477">https://bugs.openjdk.java.net/browse/JDK-6760477</a>
  <o:p></o:p></p>
        <p class="MsoNormal">Webrev:  <a moz-do-not-send="true"
            href="http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/">http://cr.openjdk.java.net/~sballal/6760477/webrev.00/</a>
  <o:p></o:p></p>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal"><span style="font-size:12.0pt"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span style="font-size:12.0pt">Thanks &amp;
            Regards,<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:12.0pt">Sharath
            Ballal<o:p></o:p></span></p>
        <p class="MsoNormal"><span style="font-size:12.0pt"><o:p> </o:p></span></p>
        <p class="MsoNormal"><o:p> </o:p></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic