[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XXS): 8171960: Event-based tracing needs separate flag representation for Method
From:       David Holmes <david.holmes () oracle ! com>
Date:       2017-01-03 0:09:34
Message-ID: 23bc088d-01e0-bbe2-407a-991ffa3d6bfa () oracle ! com
[Download RAW message or body]

Hi Markus,

On 23/12/2016 9:29 PM, Markus Gronlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following fix:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8171960
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8171960/webrev01/
>
> Summary:
>
> In order to fix a closed confidential bug, I would need to separate the
> flag representation that is currently being used by the Event-based
> tracing framework for Method.
>
> The separate flag representation will be non-existent by default; it
> will only materialize under the conjunction (INCLUDE_TRACE AND
> implementation available).
>
> The existing bit will be removed from the Flags enum with the associated
> accessors.

This looks good to me. It is nice to the the jfr specific logic no 
longer evident in the open code.

Thanks,
David
-----


>
>
> Thank you
>
> Markus
>
>
>
>
>
>
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]