[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Review request for 6895875: Missing serialVersionUID in sun.management classes
From:       Alan.Bateman () Sun ! COM (Alan Bateman)
Date:       2009-10-28 18:36:24
Message-ID: 4AE88F28.10002 () sun ! com
[Download RAW message or body]

Mandy Chung wrote:
> :
> I'm unsure if that's the reason.  j.u.l.LoggingMXBean extends 
> j.l.management.PlatformManagedObject before the fix for 6876135.  
> There should be no dependency change as I can see.  I suspect it's 
> related to some changesets pushed in the last 2 weeks and this fix 
> happens to trigger this build issue.  When I first have the fix for 
> 6876135 ~ 2 weeks ago, I was able to build my repository successfully 
> but no longer now.
>
> In any case, fixing the warning errors is a good thing.  Unfortunately 
> I'm not able to add -Xlint:serial -Werror in 
> make/java/management/Makefile as it triggers compilation error in 
> other part of the JDK.  I'll file a CR and hopefully one day we have a 
> javac-warning-free build.
I agree. There has been some progress on this (at least in the cores 
libs) but there are still a lot of serializable classes that don't have 
an explicit serialVersionUID.


>
> Webrev at:
>  http://cr.openjdk.java.net/~mchung/6895875/webrev.01/
The updated webrev looks good to me.

-Alan.

[prev in list] [next in list] [prev in thread] [next in thread]