[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8092102: Labeled: truncated property [v9]
From:       Ambarish Rapte <arapte () openjdk ! org>
Date:       2024-04-30 11:58:11
Message-ID: lHraH7jnP6nx7Ewkl1G99lCstdlZz3oqvw5RfuCnqZk=.ba25de8c-9351-47b4-8188-8c59ae5b7ad8 () github ! com
[Download RAW message or body]

On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > Adds **Labeled.textTruncated** property which indicates when the text is visually \
> > truncated (and the ellipsis string is inserted) in order to fit the available \
> > width. 
> > The new property reacts to changes in the following properties:
> > - ellipsisString
> > - font
> > - height
> > - text
> > - width
> > - wrapText
> > 
> > I don't think it's worth creating a headful test (headless won't work) due to \
> > relative simplicity of the code. 
> > **Alternative**
> > 
> > The desired functionality can be just as easily achieved on an application level, \
> > by adding a similar property to a subclass.  What is the benefit of adding this \
> > functionality to the core? 
> > UPDATE 2024/03/07: turns out Labeled in a TableView (in a TreeTableView as well) \
> > lives by different rules (TableCellSkinBase:152, TreeTableCellSkin:126).  The \
> > consequence of this is that the new functionality **cannot** be fully implemented \
> > with the public APIs alone. 
> > **See Also**
> > 
> > * [JDK-8327483](https://bugs.openjdk.org/browse/JDK-8327483) TreeView: Allow for \
> >                 tooltip when cell text is truncated
> > * [JDK-8205211](https://bugs.openjdk.org/browse/JDK-8205211) Ability to show \
> > Tooltip only when text is shown with ellipsis (...)
> 
> Andy Goryachev has updated the pull request with a new target base due to a merge \
> or a rebase. The pull request now contains 15 commits: 
> - missing )
> - review comments
> - Merge branch 'master' into 8092102.truncated
> - add exports
> - added unit tests
> - Merge remote-tracking branch 'origin/master' into 8092102.truncated
> - test
> - Merge remote-tracking branch 'origin/master' into 8092102.truncated
> - Merge branch 'master' into 8092102.truncated
> - labeled helper
> - ... and 5 more: https://git.openjdk.org/jfx/compare/0eb4d719...aa28eb4e

Testing looks good. Works as expected.
The change looks good. Please allow me a little more time to take a more closer look.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1389#issuecomment-2085127845


[prev in list] [next in list] [prev in thread] [next in thread]