[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8313138: Horizontal Scrollbar Keyboard enhancement [v5]
From:       Alexander Zuev <kizune () openjdk ! org>
Date:       2024-04-30 9:46:14
Message-ID: vsXQ-qR5NiI5qE5CXa2_2VrufH2Zhj2Gkln-wWE9YWg=.2de02c84-6f2e-47c1-9024-942a5706699f () github ! com
[Download RAW message or body]

On Mon, 8 Apr 2024 18:19:22 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> > Andy Goryachev has updated the pull request with a new target base due to a merge \
> > or a rebase. The incremental webrev excludes the unrelated changes brought in by \
> > the merge/rebase. The pull request contains 14 additional commits since the last \
> > revision: 
> > - tests
> > - cleanup
> > - node orientation
> > - Merge remote-tracking branch 'origin/master' into 8313138.horizontal
> > - table view behavior
> > - tree view behavior
> > - list view behavior
> > - orientation
> > - Merge remote-tracking branch 'origin/master' into 8313138.horizontal
> > - Merge branch 'master' into 8313138.horizontal
> > - ... and 4 more: https://git.openjdk.org/jfx/compare/0ee41fb4...5bae5e7a
> 
> Looks good.

> @azuev-java does the choice of key combination make sense?

Perfectly fine. When Voice Over is active it will override any defined key \
combination but with Voice Over we do not really care about the scrolling for better \
readability - and if there is any element that can be selected with VO cursor it will \
do scrolling by itself.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1393#issuecomment-2084850013


[prev in list] [next in list] [prev in thread] [next in thread]