[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8316372: Monkey Tester Application Part 3 [v7]
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2024-03-28 19:19:36
Message-ID: 9rN6jjryLsIoAJYBBMppt-vkEitUBP1t1a6B4PJr7d0=.d9306d8b-5672-44fc-8968-4f2451cd554b () github ! com
[Download RAW message or body]

On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> > Further changes to the MonkeyTester application:
> > 
> > - remember split pane divider ✔
> > - use 'private' instead of 'protected' in many cases ✔
> > - added more scripts to the 'writing systems' text sample ✔
> > - added RTL window control menu ✔
> > - added embedded swing/fx in tools ✔
> > - added copy popup menu in clipboard viewer ✔
> > - added the custom css field to the css playground tool ✔
> > - added many new pages ✔
> > - split XYChartPage into separate pages ✔
> > - switched to use property sheets (some choices might be incomplete) ✔
> > 
> > https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md
> >  
> > These are all the changes I could make in this test sprint, other improvements \
> > will go to the follow-up ticket https://bugs.openjdk.org/browse/JDK-8328828
> 
> Andy Goryachev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> spinner

Looks good.  I ran through several of the new and existing pages.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1967067101


[prev in list] [next in list] [prev in thread] [next in thread]