[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: JDK-8328750: [TestBug] Improve Stub Font Support
From:       Marius Hanl <mhanl () openjdk ! org>
Date:       2024-03-27 22:49:36
Message-ID: Yx83h5dHKej7gi_6uHa4UzoFiSmXG7FPebca2Tl7wi4=.a577f11d-4bfd-40e2-83a3-20b57af252d7 () github ! com
[Download RAW message or body]

On Thu, 21 Mar 2024 22:06:42 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings of the \
> stub font implementation. As I don't want to clutter the PR with that, I decided to \
> cherrypick the improvements I did to a new ticket and PR. 
> The current implementation has the following shortcomings:
> - It does not reliable detect the System Font, as a consequence, tests in \
>                 TableColumnHeaderTest.java are failing on my local machine
> - Another consequence of this is, that the font size is always estimated with 0, as \
>                 it is not detected
> - One shortcoming currently is, that the stub font siie estimate is not considering \
> bold fonts. That would improve writing tests for some scenarios, e.g. for \
> TableColumnHeader, where we would expect that the size of the header is bigger \
> since it is bold 
> Some tests were failing for the following reasons:
> - `AreaChartTest.java` - `expected -30.0, was -30.00000000004` - I added rounding \
>                 to the data.
> - `StackedBarChartTest.java` - since we now calculate correctly, the path changed
> - A test tried to load `Helvetica`, which is not supported in the stub font loader. \
>                 I changed it
> - The default System font is considered a `Regular` one (style) - just like in \
> JavaFX 
> I wrote tests and documented the stub behaviour.
> I did some minor changes here:
> - System font is now detected, also in bold and italic
> - A bold font will be calculated with a little bit more width (1px). Checkout the \
> test as well for that 
> Note: This only changes test setup, no 'production' code.

This pull request has now been integrated.

Changeset: 6adbcffa
Author:    Marius Hanl <mhanl@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/6adbcffafd15f9f771c09afb03649e83e9e0b02a
                
Stats:     359 lines in 8 files changed: 238 ins; 21 del; 100 mod

8328750: [TestBug] Improve Stub Font Support

Reviewed-by: angorya

-------------

PR: https://git.openjdk.org/jfx/pull/1422


[prev in list] [next in list] [prev in thread] [next in thread]