[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]
From:       Sai Pradeep Dandem <duke () openjdk ! org>
Date:       2023-10-31 21:55:20
Message-ID: Pc0xO3zPV2o5h7wH-ar9AQ9LjeDtHWp6AbgM-J76Llc=.6b1c8afd-a1d6-45ca-92ba-7dc99f5ea24c () github ! com
[Download RAW message or body]

> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() \
> gives unexpected results. 
> **Cause:**
> There is no check for checking the psuedo states matching in the applies() method \
> of SimpleSelector.java. So checking for "applies()" alone is not sufficient in \
> lookup() method. 
> **Fix:**
> Included an extra check for the psuedo states to match.

Sai Pradeep Dandem has updated the pull request incrementally with one additional \
commit since the last revision:

  8185831: Changes to doc as per review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1245/files
  - new: https://git.openjdk.org/jfx/pull/1245/files/6cf88c91..bd9f6bf3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=12
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=11-12

  Stats: 19 lines in 1 file changed: 1 ins; 4 del; 14 mod
  Patch: https://git.openjdk.org/jfx/pull/1245.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1245/head:pull/1245

PR: https://git.openjdk.org/jfx/pull/1245


[prev in list] [next in list] [prev in thread] [next in thread]