[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v3]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-08-31 15:29:09
Message-ID: coEuaCVqNafIkXMIvvmD68pId9zKpEKI7q-7hOahAow=.cb94c54e-0f1b-4494-8f59-94928d4d04f8 () github ! com
[Download RAW message or body]

On Wed, 30 Aug 2023 17:50:37 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> > Create implementation for Slider and Stepper accessibility protocols.
> > Fix mapping.
> > Fix performAction parameter type in declaration.
> 
> Alexander Zuev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fixing warnings during build

Testing with macOS 13.3.1a and Voice Over, using MonkeyTester 
https://github.com/andy-goryachev-oracle/MonkeyTest

Observed a number of things, some possibly not related to this PR:

1. had color picker custom color dialog opened when turning on VoiceOver, saw stderr \
                output:
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message \
transform method call failed at \
open/src/java.instrument/share/native/libinstrument/JPLISAgent.c line: 873

2. color picker, custom color: hue slider is not accessible

3. color picker, slider (opacity):
- shows 46 (%), announces: 46.3
- no NSLog debug output if using left/right arrow
- when entering slider via shift-ctrl-option-down arrow, does not announce how to \
                control the slider (as it did with spinner).
- when controlling the spinner with ctrl-option-up/down, I see NSLog debug output:

2023-08-31 08:09:03.087 java[45918:3234828] Slider decrement action invoked
2023-08-31 08:09:04.565 java[45918:3234828] Slider increment action invoked

4. spinner: see debug output when using ctrl-option-up/down, but change in value is \
not announced 2023-08-31 08:05:12.267 java[45918:3234828] Stepper decrement action \
invoked 2023-08-31 08:05:13.192 java[45918:3234828] Stepper increment action invoked

5. spinner: when in spinner (via shift-ctrl-option-down), trying to control the \
spinner via ctrl-option-up/down, releasing the last button moves the focus to the \
menu instead of staying in the spinner.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1226#issuecomment-1701259757


[prev in list] [next in list] [prev in thread] [next in thread]