[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-openjfx-dev
Subject: Re: RFR: 8307076: gradle test should always run tests
From: Johan Vos <jvos () openjdk ! org>
Date: 2023-04-29 20:08:53
Message-ID: 7DDRVR1mHOzBpfhodzNeNunFUzTBicfxSyPjcYIvrBU=.522ddc39-f0df-4d6a-b620-980d81125d67 () github ! com
[Download RAW message or body]
On Sat, 29 Apr 2023 13:48:28 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
> "gradle test" won't rerun a test that has already passed. This is surprising \
> behavior, especially for UI toolkit tests where there might be many reasons to want \
> to run the tests again, even if none of that tests "inputs" have changed. This is \
> especially bothersome when debugging an intermittent test failure. Unlike \
> rebuilding the JavaFX runtime or the docs, where there is no need to rerun a task \
> that was successful if none of the inputs to that task have changed, I expect \
> gradle to run my test when I tell it to.
> This PR will make test tasks always run when specified.
Marked as reviewed by jvos (Reviewer).
This is a major enhancement. The non-rerunning tests have been extremely annoying, \
glad this could be fixed with such a simple PR!
-------------
PR Review: https://git.openjdk.org/jfx/pull/1120#pullrequestreview-1407020797
PR Comment: https://git.openjdk.org/jfx/pull/1120#issuecomment-1528860878
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic