[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8306447: Adding an element to a long existing list may cause the first visible element to j
From:       Johan Vos <jvos () openjdk ! org>
Date:       2023-04-29 20:06:23
Message-ID: v0VeaBmIhYLjhohFfskE1M-vRJUxH_XvWYo2LXDIQgU=.f88e6c41-5afc-430e-9a69-3407df7a3b7c () github ! com
[Download RAW message or body]

On Wed, 19 Apr 2023 13:13:45 GMT, Johan Vos <jvos@openjdk.org> wrote:

> Calculate position of first visible element before propagating changes.
> Make sure to restore the position of said element after the changes are done.
> 
> Fix JDK-8306447

> When testing with the MonkeyTester #1097 , noticed that the view position still \
> jumps when adding an item if the list is scrolled to somewhere in the middle, see \
> the attached video clip. 
> 2024-0424-adding-element.mp4 
> Could I be missing something?

Not sure I understand this scenario, but I extended the existing test and fixed a \
case where the index/offset might change when the cellcount changes.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1099#issuecomment-1528859922


[prev in list] [next in list] [prev in thread] [next in thread]