[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8216507: StyleablePropertyFactory: example in class javadoc does not compile [v2]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2022-12-23 17:32:58
Message-ID: OnPXYDhfM2qSAQ8JekC4HIX3qrwf2l5SoChxBl9DdVA=.ae2b499c-f764-4ab5-81fe-e92341cb2c42 () github ! com
[Download RAW message or body]

On Fri, 23 Dec 2022 17:26:22 GMT, Karthik P K <kpk@openjdk.org> wrote:

> > Do you think it's worth doing this as a unit test?
> 
> I think it is good to add unit test to test the example code. Only thing I'm \
> looking at is that if the example changes in future, we need to make sure that \
> corresponding `MyButton` class is updated in unit test.  Since the example code \
> might not change frequently, we can add unit test.

I agree, let's add a unit test, unless  `StyleablePropertyFactoryTest` covers the \
same scenario.

-------------

PR: https://git.openjdk.org/jfx/pull/983


[prev in list] [next in list] [prev in thread] [next in thread]