[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8196065: ListChangeListener getRemoved() returns items that were not removed.
From:       Michael =?UTF-8?B?U3RyYXXDnw==?= <mstrauss () openjdk ! java ! net>
Date:       2021-06-28 9:59:07
Message-ID: mySASWx6SrQgI9HiMxlxMPTgVQATssnXdQuJ5bycCaw=.9d900ca5-f2a9-46fc-b4d4-77ed351deca3 () github ! com
[Download RAW message or body]

On Fri, 23 Apr 2021 03:19:03 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> The documentation for `ObservableListBase.nextRemove` states that a single change \
> always refers to the current state of the list, which likely means that multiple \
> disjoint removed ranges need to be applied in order, otherwise the next change's \
> `getFrom` doesn't refer to the correct index. 
> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, \
> which means that subsequent removals will refer to the wrong index when retrieving \
> the removed elements. This PR fixes the calculation of the current index.

This pull request has now been integrated.

Changeset: c4cc9988
Author:    Michael Strauß <mstrauss@openjdk.org>
Committer: Ambarish Rapte <arapte@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/c4cc99882928e423003d54cae0a6b0de2ec05007
                
Stats:     321 lines in 8 files changed: 291 ins; 6 del; 24 mod

8196065: ListChangeListener getRemoved() returns items that were not removed.

Reviewed-by: arapte, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/478


[prev in list] [next in list] [prev in thread] [next in thread]