[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2021-06-28 9:55:08
Message-ID: ciqKUL5wICK48eXTd22MPxw9afrDUB96qbvmdJ8eyqg=.90d52117-1a1a-49b3-8e09-8c262998ed9b () github ! com
[Download RAW message or body]

On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> > ~~Question: I was wondering, should I create a ticket for this as well? Given the \
> > fact that I don't have an https://bugs.openjdk.java.net account, I need to use \
> > the official bug reporting tool, which looked a bit overkill to me since someone \
> > needs to check my created ticket, while this PR is only affecting the IntelliJ \
> >                 IDE with OpenJFX and not the JavaFX platform directly.~~
> > EDIT: Thank you, Kevin. :)
> > 
> > This PR fixes the errors you get when cloning and working with OpenJFX in \
> >                 IntelliJ IDE:
> > - The **.idea/misc.xml** is modified to use **JDK_11** as language level instead \
> >                 of JDK_8. 
> > -> This is the language level shown inside the **Project Structure**. (File -> \
> >                 Project Structure...)
> > - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, \
> > .idea/graphics.iml** are modified to include/recognize the shims (as test \
> > resource, this is very similar to the configuration inside the .classpath file \
> >                 from Eclipse)
> > - EDIT: The projects are now recognized by IntelliJ-gradle (**.idea/gradle.xml**, \
> > **.idea/compiler.xml**) 
> > **-> With this, I can run all normal tests with IntelliJ**
> > 
> > ### What I couldn't fix yet (When I tried, it looked like IntelliJ is overriding \
> >                 the settings on next gradle reload): 
> > - IntelliJ is not detecting javafx.graphic inside the shims
> > - All javafx.* dependencies are not found for the system tests
> > 
> > **-> If someone has a solution, feel free to comment :)**
> 
> Marius Hanl has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Reverted whitespace made by IntelliJ

Approving, I re-verified the change: Loading project in IntelliJ does not cause any \
other changes in idea files.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/506


[prev in list] [next in list] [prev in thread] [next in thread]