[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: JDK-8177635: Optimise CSS lookup resolution
From:       Dean Wookey <wookey.dean () gmail ! com>
Date:       2021-01-29 18:26:22
Message-ID: CAKZ_BFj0qHHUYmCc7AWsyvok1R+iS49xkjmFA_J4moN9wvXK7A () mail ! gmail ! com
[Download RAW message or body]

Hi David,

We experimented with some changes last year which we've been running. We
haven't noticed any problems and we do get some good memory and speed
enhancements.. I've been meaning to clean it up before considering a pull
request, but since this is a delicate area, I've procrastinated a bit in
doing that.

Here are the changes
https://github.com/openjdk/jfx/compare/master...DeanWookey:CleanerPseudoClassEnhancements
.

I could look at redoing the changes cleaner if you think we've taken the
right approach, else if not, feel free to incorporate any of the ideas in
there in what you're doing.

Dean


On Fri, Jan 29, 2021 at 5:11 PM Kevin Rushforth <kevin.rushforth@oracle.com>
wrote:

> Hi David,
>
> That would be great, if a safe fix can be found (I don't need to tell
> you how fragile the CSS code is when it comes to these sorts of
> optimizations).
>
> Thanks!
>
> -- Kevin
>
>
> On 1/29/2021 7:02 AM, David Grieve wrote:
> > Anyone mind if I take a crack at 8177635: Optimise CSS lookup resolution?
>
>
[prev in list] [next in list] [prev in thread] [next in thread]