[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
From:       Rony G.Flatscher <github.com+60214806+ronyfla () openjdk ! java ! net>
Date:       2020-02-27 15:03:37
Message-ID: YcNN_FBaNg5Sq9jRGO5tInJM_sj9M0LMelJnlyDzJGU=.909fca4d-5b0b-49eb-a795-637148d4542d () github ! com
[Download RAW message or body]

> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

The pull request has been updated with 6 additional commits.

-------------

Added commits:
 - 8821d25a: Removed executable bit from gradlew as this causes an error when
 - 799a8148: Merge branch 'scripttest' into script as requested by reviewer Kevin
 - 2db31713: Incorporating Kevin Rushfort's review comments to this WIP.
 - 8cf0a6ec: Incorporating Kevin Rushfort's review comments to this WIP.
 - 6e4df77d: Removed/replaced white space.
 - e2519967: test for <https://bugs.openjdk.java.net/browse/JDK-8234959> JDK-8234959: \
FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/122/files
  - new: https://git.openjdk.java.net/jfx/pull/122/files/30539592..8821d25a

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/122/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/122/webrev.00-01

  Stats: 899 lines in 14 files changed: 896 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/122.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/122/head:pull/122

PR: https://git.openjdk.java.net/jfx/pull/122


[prev in list] [next in list] [prev in thread] [next in thread]