[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
From:       Rony G.Flatscher <github.com+60214806+ronyfla () openjdk ! java ! net>
Date:       2020-02-27 15:03:37
Message-ID: Bh1LjVNvy26QwJOVC-sETw1h8bNjEf9OCVrsSpm6zQM=.542239dc-cba6-4122-931a-c8e3d8dd0a54 () github ! com
[Download RAW message or body]

On Wed, 26 Feb 2020 23:37:11 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > @aghaisas can you also review this?
> 
> Overall this looks good to me. As I mentioned in PR #123 you should fold that the \
> unit test into this PR.

Removed executable bits from gradlew (which I manually have added to become able to \
run ./gradlew) and pushed it, however the commit has not appeared. Not wanting to add \
more noise, I stop until advised differently.

-------------

PR: https://git.openjdk.java.net/jfx/pull/122


[prev in list] [next in list] [prev in thread] [next in thread]