[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2019-10-31 21:20:55
Message-ID: XC4Tr7q9xh5x82s0MzKaqaWkK0Xb_254b6ZrAsIKvlg=.2a43a45b-8a9d-4eab-918c-bb27651d36db () github ! com
[Download RAW message or body]

On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8233040
> 
> The issue is that the eventFilter in CBPC uses F4 for toggling the popup _and_ \
> consumes it. This prevents client code to register there own filter.  
> The fix was to remove the block entirely - F4 is already handled by a keyMapping in \
> ComboBoxBehaviorBase. Added test that fails before the change and passes after, old \
> tests are all passing. 
> ----------------
> 
> Commits:
> - 2f015406: Fix: ComboBoxPopupControl - remove eventFilter for F4
> 
> Changes: https://git.openjdk.java.net/jfx/pull/28/files
> Webrev: https://webrevs.openjdk.java.net/jfx/28/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8233040
> Stats: 159 lines in 2 files changed: 153 ins; 6 del; 0 mod
> Patch: https://git.openjdk.java.net/jfx/pull/28.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/28/head:pull/28

The PR title should match the bug title, so:

8233040: ComboBoxPopupControl: remove eventFilter for F4

@aghaisas can you review this, and also comment on whether you feel it needs a second \
reviewer (probably not unless you find something during the review that invites a \
more careful review).

PR: https://git.openjdk.java.net/jfx/pull/28


[prev in list] [next in list] [prev in thread] [next in thread]