[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Request for permission to backport fixes to jfx-11
From:       Johan Vos <johan.vos () gluonhq ! com>
Date:       2019-10-24 17:10:40
Message-ID: CABxFH2FL=hnRf_t7feNe0gWajaD-a3Cdq=+YJCxfZxKWqsDiWA () mail ! gmail ! com
[Download RAW message or body]

Looking a bit deeper into it, it seems there are some related issues that
might be caused by the same root cause, or by this fix.
I'll request to backport it once we have more insight about the potential
regressions.

- Johan

On Tue, Oct 22, 2019 at 1:47 PM Johan Vos <johan.vos@gluonhq.com> wrote:

> I'm ok with the backport, as long as the patch applies clean -- which it
> most likely does, as I don't think we have other changes in that file.
>
> - Johan
>
> On Mon, Oct 21, 2019 at 11:15 PM Kevin Rushforth <
> kevin.rushforth@oracle.com> wrote:
>
>> > JDK-8193502
>>
>> Johan can comment on whether he wants to backport it. As noted below,
>> someone reported a regression associated with it when using gtk2, but we
>> don't have a bug filed or a test case.
>>
>> > It might have been solved in the fix for JDK-8179073.
>>
>> Not sure what you mean since JDK-8179073 is still an open bug and thus is
>> not a solved issue (although it might be worth re-testing after the fix for
>> JDK-8179073).
>>
>> -- Kevin
>>
>>
>> On 10/21/2019 1:08 PM, Sverre Moe wrote:
>>
>> Could JavaFX 11 also get backported the fix related for JDK-8193502? It
>> might have been solved in the fix for JDK-8179073.
>>
>> I noticed this regression right after JDK 9 build 161. Recently also
>> JavaFX 8 got this regression after update 181.
>>
>> It seems this was fixed in JavaFX 13.
>> I asked on GitHub in #222 a while back if this could be backported.
>> Considering that repository is now closed, I will repeat it here.
>>
>> Kevin Rushforth wrote:
>> > That's a good question for @johanvos -- it seems this might be a good
>> candidate for backport, although there is one report of a possible
>> regression caused by this fix when using GTK 2 as reported in #475
>>
>> /Sverre
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8193502
>> [2] https://bugs.openjdk.java.net/browse/JDK-8179073
>> [3] https://github.com/javafxports/openjdk-jfx/pull/456
>> [4] https://github.com/javafxports/openjdk-jfx/issues/222
>>
>> man. 21. okt. 2019 kl. 14:39 skrev Kevin Rushforth <
>> kevin.rushforth@oracle.com>:
>>
>>> +1
>>>
>>> -- Kevin
>>>
>>> On 10/21/2019 3:16 AM, Johan Vos wrote:
>>> > Hi Kevin,
>>> >
>>> > I request permission to backport the following issues to the jfx-11
>>> > repository. All patches apply clean or with minor changes (e.g.
>>> > build.properties must keep jfx.release.major.version to 11)
>>> >
>>> > Thanks,
>>> >
>>> > - Johan
>>> >
>>> > https://bugs.openjdk.java.net/browse/JDK-8221302 : Upgrade to gcc 8.2
>>> on
>>> > Linux
>>> > https://bugs.openjdk.java.net/browse/JDK-8221299 : Upgrade to Visual
>>> Studio
>>> > 2017 version 15.9.6
>>> > https://bugs.openjdk.java.net/browse/JDK-8221300 : Upgrade to Xcode
>>> 10.1
>>> > https://bugs.openjdk.java.net/browse/JDK-8214716 : Record the
>>> versions of
>>> > tools used to build FX in the repo
>>> > https://bugs.openjdk.java.net/browse/JDK-8222788 : javafx.web build
>>> fails
>>> > on XCode 10.2
>>> > https://bugs.openjdk.java.net/browse/JDK-8225203 : Update SQLite to
>>> version
>>> > 3.28.0
>>> > https://bugs.openjdk.java.net/browse/JDK-8219362 : Update to 608.1
>>> version
>>> > of WebKit
>>> > https://bugs.openjdk.java.net/browse/JDK-8227079 : Cherry pick GTK
>>> WebKit
>>> > 2.24.3 changes
>>> > https://bugs.openjdk.java.net/browse/JDK-8230361 : [web] Cookies are
>>> not
>>> > enabled in WebKit v608.1
>>> > https://bugs.openjdk.java.net/browse/JDK-8229328 : [windows]
>>> > PlatformFileHandle type should be JGObject rather than void *
>>> > https://bugs.openjdk.java.net/browse/JDK-8227431 : [Windows] Fix
>>> assertion
>>> > failure on X86 32-bit when enabling CLOOP based JavaScript interpreter
>>> > https://bugs.openjdk.java.net/browse/JDK-8222912 : Websocket client
>>> doesn't
>>> > work in WebView
>>> > https://bugs.openjdk.java.net/browse/JDK-8226537 : Multi-level
>>> > Stage::initOwner can crash gnome-shell or X.org server
>>> > https://bugs.openjdk.java.net/browse/JDK-8212060 : [GTK3] Stage
>>> sometimes
>>> > shown at top-left before moving to correct position
>>> > https://bugs.openjdk.java.net/browse/JDK-8211302 : DragAndDrop no
>>> longer
>>> > works with GTK3
>>> > https://bugs.openjdk.java.net/browse/JDK-8213510 : MediaPlayer does
>>> not
>>> > play some mp3 with artwork stream in mjpeg
>>> > https://bugs.openjdk.java.net/browse/JDK-8207942: Add new protected
>>> > VirtualFlow methods for subclassing
>>>
>>>
>>
[prev in list] [next in list] [prev in thread] [next in thread]