[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Approved] RFR: 8232929: Duplicate symbols when building static libraries
From:       Kevin Rushforth <kcr () openjdk ! org>
Date:       2019-10-24 12:15:11
Message-ID: 2MDvzLyIUrNg-x50ERAwmUzPmOebJZGHmhHbw3bgeng=.8873d3fe-d688-448a-a543-37dbdb646624 () github ! com
[Download RAW message or body]

On Thu, 24 Oct 2019 07:43:44 GMT, Johan Vos <jvos@openjdk.org> wrote:

> This PR only affects native code in the prism-sw pipeline.
> 
> JBS issue: https://bugs.openjdk.java.net/browse/JDK-8232929
> 
> ----------------
> 
> Commits:
>  - 9afeca00: Avoid name clashes when creating static libraries. Prefix exposed functions.
> 
> Changes: https://git.openjdk.java.net/jfx/pull/21/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/21/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8232929
>   Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/21.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/21/head:pull/21

+1

This seems like a simple enough fix that 1 reviewer is sufficient.

----------------

Approved by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/21
[prev in list] [next in list] [prev in thread] [next in thread]