[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    [10] Review Request: JDK-8179399 - Call trim() when loaded jre.list (Vivek Rao)
From:       Vivek Rao <vivek.x.rao () oracle ! com>
Date:       2017-06-21 19:01:33
Message-ID: 0D5998FE-19D4-48A9-AE39-A714052449FD () oracle ! com
[Download RAW message or body]

Hi, 

Chris, Victor, 
Please review the following change for fixing the "stripComments" method for \
redistributableModules. 

Bug URL: https://bugs.openjdk.java.net/browse/JDK-8179399 \
                <https://bugs.openjdk.java.net/browse/JDK-8179399>
Webrev: http://cr.openjdk.java.net/~vrao/JDK-8179399/ \
<http://cr.openjdk.java.net/~vrao/JDK-8179399/>

Issue: 
1. When each line of jre.list is loaded in RedistributableModules.java trim() should \
be called 2. NoSuchElementException not caught for ModuleReference 
3. Unused imports

Fix: 
Using trim() inside stripComments to remove unnecessary space and cleaning the if \
else condition. Added NoSuchElementException
Removed all unused imports

Thanks and regards, 
Vivek Rao


[prev in list] [next in list] [prev in thread] [next in thread]