[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (S) 8031045: Access checks should precede additional per-instruction checks
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2014-01-22 18:36:06
Message-ID: 52E00F96.8070109 () oracle ! com
[Download RAW message or body]

Thanks for the review!

Harold
On 1/22/2014 8:20 AM, frederic parain wrote:
> Looks good to me.
>
> Fred
>
> On 22/01/2014 14:08, harold seigel wrote:
>> Hi,
>>
>> Please review this straightforward backport of this small fix for bug
>> 8031045 to JDK-8u.  The fix changes the implementation so that it does
>> an access check before doing the non-static method ICCE error check.
>> This ensures that if the method is both not accessible and not static,
>> that an IllegalAccessError exception will get throw.  The fix is the
>> same for both JDK-9 and JDK-8u.
>>
>> This fix was tested with the test in the bug report, the JCK lang and vm
>> tests, the defmeth tests, the ute mlvm and quick tests, and the hotspot,
>> java util, and java lang jtreg tests.
>>
>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8031045_8u/
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8031045_8u/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031045
>>
>> Thanks! Harold
>

[prev in list] [next in list] [prev in thread] [next in thread]