[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 	JDK-8032250 : Add trace event for VM flag changes
From:       Coleen Phillmore <coleen.phillimore () oracle ! com>
Date:       2014-01-22 16:19:37
Message-ID: 52DFEF99.4020306 () oracle ! com
[Download RAW message or body]


On 1/22/2014 11:17 AM, Staffan Larsen wrote:
> A couple of places in globals.cpp has changed from "<EventLongFlagChanged, s8>" to \
> "<EventUnsignedLongFlagChanged, u8>".

Oh, yeah, I saw that :)
> 
> (How I wish we had a review system where it was easy to see diffs between \
> versions…)

I think crucible is coming soon.  Anyway, please ship your change since 
Erik says it's ok.

thanks,
Coleen


> 
> /Staffan
> 
> On 22 jan 2014, at 16:53, Coleen Phillmore <coleen.phillimore@oracle.com> wrote:
> 
> > Okay, so he's a better reviewer than I am.   What is the diff between the two \
> > versions? Thanks,
> > Coleen
> > 
> > On 1/22/2014 10:28 AM, Erik Helin wrote:
> > > Hi Staffan,
> > > 
> > > the change looks good now :)
> > > 
> > > Thanks,
> > > Erik
> > > 
> > > On 2014-01-22 16:02, Staffan Larsen wrote:
> > > > Erik discovered that I used traced events with signed values for some \
> > > > unsigned flag types. 
> > > > So, new revision: http://cr.openjdk.java.net/~sla/8032250/webrev.02/
> > > > 
> > > > Thanks,
> > > > /Staffan
> > > > 
> > > > On 22 jan 2014, at 15:08, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> > > > 
> > > > > Erik Helin suggested using template functions instead of macros which makes \
> > > > > the code a little more type safe. 
> > > > > Also added a missing #include in globals.cpp.
> > > > > 
> > > > > Here is a new version of the webrev: \
> > > > > http://cr.openjdk.java.net/~sla/8032250/webrev.01/ 
> > > > > Thanks,
> > > > > /Staffan
> > > > > 
> > > > > On 21 jan 2014, at 14:47, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> > > > > 
> > > > > > This is a patch to capture a trace event whenever a manageable VM flag is \
> > > > > > changed in runtime. 
> > > > > > webrev: http://cr.openjdk.java.net/~sla/8032250/webrev.00/
> > > > > > bug: https://bugs.openjdk.java.net/browse/JDK-8032250
> > > > > > 
> > > > > > Thanks,
> > > > > > /Staffan


[prev in list] [next in list] [prev in thread] [next in thread]