[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR(XS): 8246023: Obsolete LIRFillDelaySlot
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2020-05-28 16:28:46
Message-ID: EBD47156-B054-4BDD-97E8-80572807E474 () oracle ! com
[Download RAW message or body]


Tobias/Vladimir, thanks for the reviews! Change pushed.

Cheers,
Mikael

> On May 28, 2020, at 7:19 AM, Vladimir Kozlov <vladimir.kozlov@oracle.com> wrote:
> 
> +1
> 
> Thanks,
> Vladimir
> 
> On 5/27/20 11:51 PM, Tobias Hartmann wrote:
> > Hi Mikael,
> > looks good and trivial to me.
> > Best regards,
> > Tobias
> > On 28.05.20 04:19, Mikael Vidstedt wrote:
> > > 
> > > Please review this small change which obsoletes the LIRFillDelaySlot flag:
> > > 
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8246023
> > > webrev: https://cr.openjdk.java.net/~mikael/webrevs/8246023/webrev.00/open/webrev
> > >                 
> > > CSR: https://bugs.openjdk.java.net/browse/JDK-8246024
> > > 
> > > Background (from JBS):
> > > 
> > > With SPARC removed (JDK-8241787) the LIRFillDelaySlot flag no longer has any \
> > > relevant effect and should be removed using the normal process. Since the flag \
> > > was really only useful on SPARC and since all the code it once controlled is \
> > > now gone the flag will go directly to obsolete, skipping the deprecation step. 
> > > Testing:
> > > 
> > > * Manual verification running with the flag: spits out the warning as expected
> > > * tier1: in progress
> > > 
> > > 
> > > Note: I believe additional cleanup is possible related to delay slots, but I'd \
> > > like to handle that separately. 
> > > Cheers,
> > > Mikael
> > > 


[prev in list] [next in list] [prev in thread] [next in thread]