[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR(XS): 8245864: Obsolete BranchOnRegister
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2020-05-28 16:10:34
Message-ID: 6B0A48C1-0DB7-4A2E-8CA8-6A9862B0298D () oracle ! com
[Download RAW message or body]


Tobias/Vladimir, thanks for the reviews! Change pushed.

Cheers,
Mikael

> On May 28, 2020, at 7:18 AM, Vladimir Kozlov <vladimir.kozlov@oracle.com> wrote:
> 
> +1
> 
> Thanks,
> Vladimir
> 
> On 5/27/20 11:49 PM, Tobias Hartmann wrote:
> > Hi Mikael,
> > looks good and trivial to me.
> > Best regards,
> > Tobias
> > On 27.05.20 23:40, Mikael Vidstedt wrote:
> > > 
> > > Please review this small change which obsoletes the BranchOnRegister flag:
> > > 
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8245864
> > > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8245864/webrev.00/open/webrev/
> > >                 
> > > CSR: https://bugs.openjdk.java.net/browse/JDK-8245865
> > > 
> > > Background (from JBS):
> > > 
> > > With Solaris removed (JDK-8241787) the BranchOnRegister flag no longer has any \
> > > effect and should be removed using the normal process. Since the flag was \
> > > really only useful on Solaris and since all the code it once controlled is now \
> > > gone the flag will go directly to obsolete, skipping the deprecation step. 
> > > Testing:
> > > 
> > > * Manual verification running with the flag: spits out the warning as expected
> > > * tier1: in progress
> > > 
> > > Cheers,
> > > Mikael
> > > 


[prev in list] [next in list] [prev in thread] [next in thread]