[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]
From:       Alisen Chung <achung () openjdk ! org>
Date:       2024-01-31 22:02:07
Message-ID: __upDL04oJsLJv8CWRb7ibgme5lTpQpM9Grh1SeTc6Q=.53304c9e-40a8-410b-89f0-8cf5febbcce2 () github ! com
[Download RAW message or body]

On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad \
<rkannathpari@openjdk.org> wrote:

> > Hi Reviewers,
> > 
> > Updated manual printer test cases with 'PassFailJFrame', also removed unused \
> > variables. Added 'SkippedException' in case of printer missing or not configured. \
> >  Please review and let me know your suggestions.
> > 
> > Regards,
> > Renjith
> 
> Renjith Kannath Pariyangad has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Capitalized static final variables

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 38:

> 36:  * @bug 4956397
> 37:  * @key printer
> 38:  * @library /java/awt/regtesthelpers

library lines on same line

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 63:

> 61: 
> 62:         new PageDlgPrnButton() ;
> 63:         passFailJFrame.awaitAndCheck();

simplifiable with 

PassFailJFrame.builder()
                .instructions(INSTRUCTIONS)
                .rows((int) INSTRUCTIONS.lines().count() + 1)
                .columns(45)
                .build()
                .awaitAndCheck();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473513477
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473517506


[prev in list] [next in list] [prev in thread] [next in thread]